Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vitamin A and B for good #55466

Merged
merged 9 commits into from
Feb 21, 2022
Merged

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Feb 17, 2022

Summary

Bugfixes "Remove vitamin A and B for good"

Purpose of change

Vitamin A and B have been useless for years, this removes them definitly from the code base.

Describe the solution

  • Remove all mentions of vitA and vitB from the json both in mods and in vanilla
  • obsolete the vitamin definitions
  • remove hardcoded mentions
  • remove mentions from test
  • remove legacy handling of their useless effect
  • obsolete vitamin B injection

Describe alternatives you've considered

Testing

load game with a save from beefore ths change without error

Additional context

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 17, 2022
@Fris0uman Fris0uman marked this pull request as ready for review February 17, 2022 21:58
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 17, 2022
@Testudo-Cultu
Copy link
Contributor

This feels like a turn in the wrong direction. Instead of removing them, why not expand on the health system so they have a use? Vitamin B deficiency wouldn't be very difficult to design. It could basically just be increased fatigue, reduced dexterity and reduced intelligence, and then later on anemia that progresses until death. The symptoms are already very similar to conditions in-game, so it feels like more effort to remove it than to just add vitamin B deficiency.

Vitamin A deficiency would basically just be a constant perception penalty and lower infection/disease resistance.

@anothersimulacrum
Copy link
Member

anothersimulacrum commented Feb 19, 2022

They are not being expanded on because they aren't things that it is feasible to be deficient in in the scope of the game. Calcium isn't either, unless you want to grow a shell (which is why it stays).

@Testudo-Cultu
Copy link
Contributor

They are not being expanded on because they aren't things that it is feasible to be deficient in in the scope of the game.

Both would be pretty easy to get from meat and livers and would be a bit less severe than scurvy, so in terms of complexity it seems pretty simple to manage. I think vitamin B and A would be the easiest way to incentivize someone not to live off of just butter and pine tea or lard and tea. I'm guessing I'm missing something, but it doesn't seem necessary to discard these entirely when we already have vitamin C.

@Venera3
Copy link
Member

Venera3 commented Feb 19, 2022

A and Bs have too large stores to develop a deficiency within the game's timeline (we're talking ~year of absolutely no intake).

@Testudo-Cultu
Copy link
Contributor

A and Bs have too large stores to develop a deficiency within the game's timeline (we're talking ~year of absolutely no intake).

Is that really out of scope, though? Just making the new plate armors can take over a third of an in-game year to pull off due to weariness and the requirement to satisfy basic needs. The faction system, while pretty much completely optional, could easily take over an in-game year just to fully develop one base. I've even had characters that spent almost an entire year just chilling in one spot eating smoked meat/pemmican every day while I tried to craft end-game stuff.

@Venera3
Copy link
Member

Venera3 commented Feb 19, 2022

Which would not be "completely no intake", but in our system anything below 0.1% RDA per serving is ignored, which throws out trace amounts -and trace intake is all you need from micro nutrients. Do give the relevant PRs over the last year a read, but the long and short of it is unless we get to multi-year games being the norm they aren't worth tracking.

@Testudo-Cultu
Copy link
Contributor

Which would not be "completely no intake", but in our system anything below 0.1% RDA per serving is ignored, which throws out trace amounts -and trace intake is all you need from micro nutrients. Do give the relevant PRs over the last year a read, but the long and short of it is unless we get to multi-year games being the norm they aren't worth tracking.

Fair enough I suppose.

@Fris0uman Fris0uman marked this pull request as draft February 20, 2022 14:59
@Fris0uman Fris0uman marked this pull request as ready for review February 20, 2022 15:50
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 20, 2022
@kevingranade kevingranade merged commit d13be28 into CleverRaven:master Feb 21, 2022
@Fris0uman Fris0uman deleted the vitamins branch February 21, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants